web: Support align embed/object attribute (part of #4258) #19079
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-web
danielhjacobs
commented
Jan 2, 2025
| case "center": | ||
| return "vertical-align: middle;"; | ||
| case "middle": | ||
| return "vertical-align: middle; vertical-align: -webkit-baseline-middle; vertical-align: -moz-middle-with-baseline;"; |
There was a problem hiding this comment.
Found in testing on Chrome. The closest page I can find to describing this behavior is https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#align. It says right and left are equivalent to float CSS, though doesn't mention the vertical-align, but it seems to be added in testing. It says top is vertical-align: top, true in testing. It says middle is vertical-align: -moz-middle-with-baseline, and in testing on Chrome it is -webkit-baseline-middle. It says bottom is vertical-align: unset, and in testing it seems to be vertical-align: baseline, which seems to be the default. It doesn't mention center, but in testing that seems to be vertical-align: middle.
danielhjacobs
added
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not added to
config/optionsasalignitself is deprecated forembed/objectelements - the same can be accomplished with the appropriate CSS.