web: Do not scroll the page when mouse wheel is handled in AVM2 #19029
+200
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-web
Useful on Chromium-based browsers, where the modal is always displayed at the beginning.
This patch prevents scrolling the page when the users scrolls content inside the SWF (i.e. when the content somehow handles the scroll).
kjarosh
force-pushed
the
web-mouse-wheel
branch
from
8daa672 to
5a374ce
Compare
This test verifies how scrolling works in AVM2 and whether the page is scrolled when it should be or not.
kjarosh
force-pushed
the
web-mouse-wheel
branch
from
5a374ce to
c51d1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents scrolling the page when the users scrolls content inside the SWF (i.e. when the content somehow handles the scroll).
Based on my testing this behavior is a lot smarter than Flash originally had, because Flash just trapped mouse wheel events. We might want to add an option to simulate this behavior too in the future.
You can easily test the behavior here: https://www.newgrounds.com/portal/view/922049.