avm2: Make TextField.getCharIndexAtPoint accurate
#18861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
kjarosh
force-pushed
the
get-char-index-at-point
branch
from
7398312 to
796f2e8
Compare
adrian17
reviewed
Dec 9, 2024
kjarosh
force-pushed
the
get-char-index-at-point
branch
2 times, most recently
from
0bf3e99 to
2e5ff5d
Compare
kjarosh
force-pushed
the
get-char-index-at-point
branch
from
2e5ff5d to
1e66262
Compare
Lord-McSweeney
approved these changes
Jan 16, 2025
This patch fixes getCharIndexAtPoint() so that it's accurate for all inputs.
This test verifies the behavior of getCharIndexAtPoint().
kjarosh
force-pushed
the
get-char-index-at-point
branch
from
1e66262 to
8a0e575
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
getCharIndexAtPoint()so that it's accurate for all inputs.