avm2: Properly implement Stage.tabChildren
#16608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
kjarosh
force-pushed
the
stage-tab-children
branch
3 times, most recently
from
72c9042 to
1265c22
Compare
Dinnerbone
approved these changes
Jun 7, 2024
Stage.tabChildren does not modify the value of tabChildren of the stage, but rather sets the tabChildren of the root movie.
This test verifies the behavior of Stage.tabChildren.
This test verifies how Stage.tabChildren behaves when the root movie is removed.
Dinnerbone
force-pushed
the
stage-tab-children
branch
from
1265c22 to
36fe419
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443. Fixes #16589.
Turns out that
Stage.tabChildren's behavior is a bit strange, because it always returnstrue, but when its value is set, it's propagated to the root movie.Covered by
avm2/tab_ordering_stage_tab_children.Additionally added "Tab children enabled" to debug UI.