-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audio: Add G.711 decoder #16570
base: master
Are you sure you want to change the base?
audio: Add G.711 decoder #16570
Conversation
is there content that this is used for? |
(or at least a crafted example so we can test with, please!) |
I don't think it should be added to the |
@Lord-McSweeney Same in 409a713#diff-00d1b36fa29c1b47759997928f850c8ff051e7bcbe201ab073f0f855f1d3ecdeR1029 |
At least I personally have changed my mind since then. Now I think it's fine. After all, we have also added H264 as VideoCodec... |
Okay, this definitely needed more testing (see #16614) |
FFmpeg commands for flv encoding |
0423463
to
ac46cfb
Compare
I'm still unable to make a passing test for this. This is what FP plays the tone as: And this is what this PR currently plays it as: Maybe the FLV parser doesn't feed the decoder enough data...? Could the same thing be causing the fairly common "MP3 decoder buffer underrun" errors? I've also noticed that a decoder is being recreated for each "packet", which is probably not optimal...? Pinging @kmeisthax. |
Based on the one for the AAC decoder.
https://en.wikipedia.org/wiki/G.711
Both a-law and mu-law implemented as lookup tables