core: Drop the focus when it's made invisible #16416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
the
waiting-on-review
Dinnerbone
approved these changes
May 28, 2024
Make sure that focus change is logged even if the focus is removed. That additionally verifies that handlers are properly called.
When an object has focus and is made invisible, the focus should be dropped.
This test verifies the behavior of focus when its visibility is changed.
Dinnerbone
force-pushed
the
focus-invisible
branch
from
07afa1e to
5d6227f
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object has focus and is made invisible, the focus should be dropped.
A test is added as always and another one is improved.
Related to #5443 as it improves
FocusManagersupport a bit in certain situations.