core: Implement proper automatic tab ordering #16323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
proper-auto-tab-order
branch
from
49c81ca to
4cf99ef
Compare
This was referenced May 14, 2024
Dinnerbone
approved these changes
May 16, 2024
torokati44
force-pushed
the
proper-auto-tab-order
branch
from
4cf99ef to
3b5397a
Compare
This test was passing totally by accident. It contained two objects that were lying on the same y=-(x-p)/6 line. Using the automatic order, only one of these objects should be tabbable, however in output.txt we can see them both (clipInner2 and clip5b). That's because the test was performed in FP with a zoom less than 100%, which apparently changed how FP sees coordinates.
This patch implements proper automatic tab ordering that behaves exactly the same as in FP. The automatic order depends only on the position of the top-left highlight bound corner, referred to as `(x,y)`. It does not depend on object's size or other corners. The value of `6y+x` is used to order objects by it. This means that the next object to be tabbed is the next one that touches the line `y=-(x-p)/6` (with the smallest `p`). When two objects have the same value of `6y+x` (i.e. when the line touches two objects at the same time), only one of them is included. This behavior is similar to the naive approach of "left-to-right, top-to-bottom", but (besides being sometimes seen as random jumps) takes into account the fact that the next object to the right may be positioned slightly higher. This is especially true for objects placed by hand or objects with different heights (as FP uses the top left corner instead of the center). This behavior has been discovered experimentally by placing tabbable objects randomly and bisecting one of their coordinates to find a difference in behavior.
This test verifies the exact behavior of the automatic tab order.
Dinnerbone
force-pushed
the
proper-auto-tab-order
branch
from
3b5397a to
d07bac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443. Fixes #15853.
This PR implements proper automatic tab ordering that behaves exactly the same as in FP.
The Behavior of Automatic Tab Ordering
The automatic order depends only on the position of the top-left highlight bound corner, referred to as
(x,y). It does not depend on object's size or other corners.The value of
6y+xis used to order objects by it. This means that the next object to be tabbed is the next one that touches the liney=-(x-p)/6(with the smallestp).When two objects have the same value of
6y+x(i.e. when the line touches two objects at the same time), only one of them is included.This behavior is similar to the naive approach of "left-to-right, top-to-bottom", but (besides being sometimes seen as random jumps) takes into account the fact that the next object to the right may be positioned slightly higher. This is especially true for objects placed by hand or objects with different heights (as FP uses the top left corner instead of the center).
The following image presents this behavior visually.
This behavior has been discovered experimentally by placing tabbable objects randomly and bisecting one of their coordinates to find a difference in behavior.