avm1: Highlight buttons using their hit bounds #16287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returns the world bounds of the focus highlight for the interactive object.
Buttons are always highlighted using their hit bounds. I guess it does have some sense to it, because their bounds usually change on hover (children are swapped out), which would cause the automatic tab order to change during tabbing. That could potentially create a loop in the tab ordering (soft locking the tab).
This test verifies how the highlight behaves for AVM1 buttons.
Dinnerbone
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443. Fixes #15851.
Buttons are always highlighted using their hit bounds.
I guess it does have some sense to it, because their bounds usually change on hover (children are swapped out), which would cause the automatic tab order to change during tabbing. That could potentially create a loop in the tab ordering (soft locking the tab).
This behavior is covered by tests of course.