avm2: Minor performance improvements #16150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a regression
|
Lord-McSweeney
force-pushed
the
avm2-misc-optimizer
branch
4 times, most recently
from
5ca0acc to
998a9c8
Compare
adrian17
reviewed
May 6, 2024
| match name_value { | ||
| Value::Integer(name_int) if name_int >= 0 => { | ||
| if let Some(mut array) = | ||
| object.as_array_storage_mut(self.context.gc_context) |
There was a problem hiding this comment.
shouldn't this rather be made similarly to op_get_property, with a "virtual" set_index_property? As written, this doesn't support vectors or bytearray.
Lord-McSweeney
force-pushed
the
avm2-misc-optimizer
branch
2 times, most recently
from
497cae7 to
c65263e
Compare
Lord-McSweeney
changed the title
Lord-McSweeney
force-pushed
the
avm2-misc-optimizer
branch
from
c65263e to
60fdc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been stripped of most of the larger changes. The only notable change remaining is a fast path for setting index properties on arrays.