avm2: TLF GroupElement improvements #13834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pony-creator.zip now gets stuck in endless loading after clicking "Play Game" button |
Do you mean after this PR? I tried with just #13226 and it also seemed to hang. |
|
Oh, the main root of the problem is #13226 I haven't tested it before, only on the last nightly build and this one. |
|
I think I figured out what Pony Creator (#9232) wants, but I'm not sure of the exact conditions under which it should be done. See: #13226 (comment) |
evilpie
force-pushed
the
tlf-groupelement
branch
from
eae5e9b to
ad78436
Compare
|
#13226 was merged so this will need a rebase. |
evilpie
force-pushed
the
tlf-groupelement
branch
from
ad78436 to
9a3082c
Compare
Dinnerbone
approved these changes
Nov 13, 2023
Dinnerbone
force-pushed
the
tlf-groupelement
branch
from
9a3082c to
77c32ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #13226. Makes #13803 somewhat playable, but the text is invisible.