-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Extension UI improvements #13473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WumboSpasm
force-pushed
the
web-ui-improvements
branch
from
October 9, 2023 22:48
e5e3c71
to
f161eb7
Compare
adrian17
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (note: let's squash on merge)
WumboSpasm
force-pushed
the
web-ui-improvements
branch
from
October 12, 2023 20:43
dc1e6b9
to
5f9a74c
Compare
Dinnerbone
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The localisation changes are a bit unfortunate but it's for the best
torokati44
force-pushed
the
web-ui-improvements
branch
3 times, most recently
from
November 3, 2023 21:38
dc09d5c
to
674ec45
Compare
Because it's not kebab-case, to match the keys of the metadata object in JS.
torokati44
force-pushed
the
web-ui-improvements
branch
from
November 3, 2023 21:46
674ec45
to
e72c5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always thought the extension UI could use a bit of work, so this is my attempt at giving it a nice visual refresh.
General changes:
Pop-up menu changes:
Settings page changes:
Player changes:
Some things to note:
Before:
After:
Before:
After:
Before:
After: