Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Extension UI improvements #13473

Merged
merged 11 commits into from
Nov 3, 2023

Conversation

WumboSpasm
Copy link
Contributor

@WumboSpasm WumboSpasm commented Oct 9, 2023

I always thought the extension UI could use a bit of work, so this is my attempt at giving it a nice visual refresh.

General changes:

  • Buttons, text/number fields, and dropdowns have been given a consistent style that reflects Ruffle's color scheme
  • English text strings have been updated to make better use of given space

Pop-up menu changes:

  • Fine-tuned padding
  • Decreased font size by 5%
  • Moved version text to underneath the logo
  • Improved aesthetics of status indicator
  • Replaced settings button into an icon

Settings page changes:

  • Version text has been added underneath the logo
  • Increased space between text and buttons
  • Slightly decreased gap between options

Player changes:

  • Improved spacing of elements in header bar
  • Removed margins around Flash content
  • Turned info modal into a toggleable sidebar

Some things to note:

  • The settings icon in the pop-up menu appears slightly smaller in Firefox, despite looking fine when viewing the HTML directly
  • The up/down arrows of the number input field are impossible to style in a way that's consistent across browsers, so they have been left untouched for now

Before:
1
After:
2

Before:
3
After:
4

Before:
5
After:
6

@WumboSpasm WumboSpasm force-pushed the web-ui-improvements branch from e5e3c71 to f161eb7 Compare October 9, 2023 22:48
Copy link
Collaborator

@adrian17 adrian17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (note: let's squash on merge)

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The localisation changes are a bit unfortunate but it's for the best

@torokati44 torokati44 force-pushed the web-ui-improvements branch 3 times, most recently from dc09d5c to 674ec45 Compare November 3, 2023 21:38
@torokati44 torokati44 merged commit 4403848 into ruffle-rs:master Nov 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants