Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blox Forever: Incorrect tab highlighting behavior #15851

Closed
waspennator opened this issue Apr 3, 2024 · 6 comments · Fixed by #16287
Closed

Blox Forever: Incorrect tab highlighting behavior #15851

waspennator opened this issue Apr 3, 2024 · 6 comments · Fixed by #16287
Labels
bug Something isn't working

Comments

@waspennator
Copy link

Describe the bug

Decided to randomly test out the tab shifting behavior now that ruffle has it somewhat implemented and i'm noticing a major difference between ruffle and flash where it doesn't seem to be highlighting the menu in the same way flash does. It takes around 7 tab clicks for the orange box to show up and it doesn't line up with how flash tab highlights this game, just seems to highlight a bunch of random stuff.

Expected behavior

Each time I press tab, it should highlight each of the menu buttons and show a visual of them being hovered over each tab click.

Content Location

https://www.newgrounds.com/portal/view/178172

Affected platform

Browser's extension

Operating system

Windows 11

Browser

Edge 123

Additional information

No response

@waspennator waspennator added the bug Something isn't working label Apr 3, 2024
@torokati44
Copy link
Member

You might be interested, @kjarosh... ?

@kjarosh
Copy link
Member

kjarosh commented Apr 3, 2024

Yeah, I also noticed that Ruffle is very liberal regarding which objects are tabbable. This is of course due to #5443 not being yet finished; I'm currently analyzing which objects FP marks as untabbable regardless of anything else, that should hopefully make this feature more usable for SWFs with large number of objects (including this one) :)) I'm working my way from ground up and treading lightly, as it's very easy to make false assumptions due to the sheer number of variables involved in the logic behind tab.

Regarding the visual, that is perhaps covered by the "It seems that focusing elements by Tab triggers some additional events?" point from #5443 (comment).

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Apr 4, 2024

Regarding the visual, that is perhaps covered by the "It seems that focusing elements by Tab triggers some additional events?" point from #5443 (comment).

Yeah, I'm guessing the onRollOver Button/MovieClip event is triggered, at the least.

@waspennator
Copy link
Author

Retested with latest nightly. It's better now since it's only highlighting the 7 menu buttons and hovers over each one with each tab press, but it's still not playing the animation when hovering over the buttons. Another quirk i'm noticing is that it doesn't seem to be centered like it is on flash when tab highlighting.

How it looks on Ruffle:
Screenshot 2024-04-05 194621

How it looks on flash:
Screenshot 2024-04-05 194649

@kjarosh
Copy link
Member

kjarosh commented Apr 6, 2024

The centering issue is caused by the lack of the hover animation, adding support for onRollOut/onRollOver will fix both.

@kjarosh
Copy link
Member

kjarosh commented Apr 11, 2024

The centering issue is caused by the lack of the hover animation, adding support for onRollOut/onRollOver will fix both.

Well I thought it will fix both, but apparently it's still off. The highlight will need some more tests and fine tuning ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants