Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use email validator instead of regex #3985

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

koladilip
Copy link
Contributor

What are the changes introduced in this PR?

regexps are hard to understand so better leave that functionality to a library widely used than managing on our own.
I found some problems with customer.io validations so fixed the same also.

What is the related Linear task?

Resolves INT-3144

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested a review from a team as a code owner January 17, 2025 03:18
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (eacfdf1) to head (7eab840).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/v0/destinations/customerio/util.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3985   +/-   ##
========================================
  Coverage    90.77%   90.77%           
========================================
  Files          624      624           
  Lines        32551    32552    +1     
  Branches      7726     7726           
========================================
+ Hits         29547    29548    +1     
- Misses        2748     2780   +32     
+ Partials       256      224   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@koladilip koladilip requested a review from ItsSudip January 20, 2025 04:32
@koladilip koladilip merged commit 24c0596 into develop Jan 20, 2025
27 checks passed
@koladilip koladilip deleted the refactor/regular-expressions branch January 20, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants