-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use email validator instead of regex #3985
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3985 +/- ##
========================================
Coverage 90.77% 90.77%
========================================
Files 624 624
Lines 32551 32552 +1
Branches 7726 7726
========================================
+ Hits 29547 29548 +1
- Misses 2748 2780 +32
+ Partials 256 224 -32 ☔ View full report in Codecov by Sentry. |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
…rudder-transformer into refactor/regular-expressions
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
regexps are hard to understand so better leave that functionality to a library widely used than managing on our own.
I found some problems with customer.io validations so fixed the same also.
What is the related Linear task?
Resolves INT-3144
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.