Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sonar issues in regex expressions #3979

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

koladilip
Copy link
Contributor

What are the changes introduced in this PR?

Fix regex issues

What is the related Linear task?

Resolves INT-3054

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested review from a team as code owners January 13, 2025 11:20
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (3c6e047) to head (6b9d487).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3979   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          622      622           
  Lines        32516    32517    +1     
  Branches      7718     7720    +2     
========================================
+ Hits         29511    29512    +1     
- Misses        2749     2781   +32     
+ Partials       256      224   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip koladilip changed the title fix: sonar issues in dynamic config fix: sonar issues in regex expressions Jan 13, 2025
utsabc
utsabc previously approved these changes Jan 13, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

ItsSudip
ItsSudip previously approved these changes Jan 14, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants