Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct endpoint for custom events #3954

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix: use correct endpoint for custom events #3954

merged 2 commits into from
Jan 3, 2025

Conversation

ItsSudip
Copy link
Member

What are the changes introduced in this PR?

We are not setting the category properly for such events which are mapped to default events. For example let's say we have the following mapping:
Rudderstack Event -> Branch Event
Item Viewed -> VIEW_ITEM

As Item Viewed is not on the list of different mappings on Rudderstak we are setting the category name as custom. But later when we get the correct event name from the destination config we are not updating the category to the respective category.

What is the related Linear task?

Resolves INT-2997

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (0965f30) to head (fa79b46).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3954      +/-   ##
===========================================
+ Coverage    90.48%   90.72%   +0.23%     
===========================================
  Files          615      617       +2     
  Lines        32359    32405      +46     
  Branches      7687     7695       +8     
===========================================
+ Hits         29281    29400     +119     
+ Misses        2822     2749      -73     
  Partials       256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yashasvibajpai
yashasvibajpai previously approved these changes Dec 30, 2024
@ItsSudip ItsSudip merged commit 49eb591 into develop Jan 3, 2025
27 checks passed
@ItsSudip ItsSudip deleted the fix.branch branch January 3, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants