Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allure integration and migration utility for component tests #3949

Merged
merged 10 commits into from
Dec 30, 2024

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Dec 24, 2024

What are the changes introduced in this PR?

Currently the component tests are not very easy to navigate and well documented. This PR aims to bridge tho following issues

Incorrect or no usage of type systems in the test

A migration utility has been introduced to migrate tests which to correct types

Upon migration the user is expected to fill the details of the test cases like descriptions and the scenario details

Visualisation problem: Right now we have visualisation tools for coverage but not to visualise and understand test cases this results in difficulties in navigating through tests cases during issues or CFD

Integration of allure test reporter for solving test visualisation and navigation

What is the related Linear task?

Resolves INT-2941

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@utsabc utsabc requested review from sivashanmukh and a team as code owners December 24, 2024 10:35
@utsabc
Copy link
Member Author

utsabc commented Dec 24, 2024

Callout: Since method is added to test types hence needed to manually add to all test cases where it was missing

@utsabc utsabc changed the title Chore.test migration ts chore: allure integration and migration utility for component tests Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (0965f30) to head (546a7dc).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3949      +/-   ##
===========================================
+ Coverage    90.48%   90.72%   +0.23%     
===========================================
  Files          615      617       +2     
  Lines        32359    32407      +48     
  Branches      7687     7694       +7     
===========================================
+ Hits         29281    29402     +121     
+ Misses        2822     2781      -41     
+ Partials       256      224      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

koladilip
koladilip previously approved these changes Dec 26, 2024
test/scripts/migrateTest.ts Outdated Show resolved Hide resolved
@utsabc utsabc merged commit 7e51661 into develop Dec 30, 2024
27 checks passed
@utsabc utsabc deleted the chore.test-migration-TS branch December 30, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants