Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade adjust source to v2 spec #3911

Closed
wants to merge 1 commit into from

Conversation

vinayteki95
Copy link
Contributor

What are the changes introduced in this PR?

This PR aims to upgrade webhook source adjust to listen to v2 specification instead of v0/v1 specification.

  • Corresponding component tests are also modified to use v2 specification

What is the related Linear task?

Resolves INT-2899
But only partially

Please explain the objectives of your changes below

This is required to avoid using new environment variables that carry a list of sources which need to parse query_parameters from the body of v0/v1 sources in transformer while doing a v2->v1/v0 conversion.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (275e971) to head (b3d9aab).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
src/v2/sources/adjust/transform.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3911      +/-   ##
===========================================
- Coverage    90.47%   90.47%   -0.01%     
===========================================
  Files          615      615              
  Lines        32320    32320              
  Branches      7677     7681       +4     
===========================================
- Hits         29242    29241       -1     
- Misses        2822     2823       +1     
  Partials       256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 New Major Issues (required ≤ 1)
6 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@vinayteki95 vinayteki95 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants