Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard shopify to v1 #3665

Merged
merged 25 commits into from
Sep 24, 2024
Merged

feat: onboard shopify to v1 #3665

merged 25 commits into from
Sep 24, 2024

Conversation

yashasvibajpai
Copy link
Member

What are the changes introduced in this PR?

  • Onboard shopify to v1 transformation
  • Add supporting transformation for new shopify pixel app, drive implementations via source config.

What is the related Linear task?

Resolves INT-2511

Please explain the objectives of your changes below

There should not be any breaking changes in the old implementation.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

Source transformations added for the new shopify pixel app.

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Aug 18, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 92.95154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 88.72%. Comparing base (d70ac5d) to head (56b1c6f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...c/v1/sources/shopify/pixelWebhookEventTransform.js 71.15% 14 Missing and 1 partial ⚠️
src/v1/sources/shopify/pixelUtils.js 98.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3665      +/-   ##
===========================================
+ Coverage    88.69%   88.72%   +0.02%     
===========================================
  Files          594      599       +5     
  Lines        32413    32639     +226     
  Branches      7727     7770      +43     
===========================================
+ Hits         28750    28960     +210     
- Misses        3342     3387      +45     
+ Partials       321      292      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai marked this pull request as ready for review September 5, 2024 12:40
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners September 5, 2024 12:40
Copy link
Member

@utsabc utsabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the requested comments

@yashasvibajpai yashasvibajpai requested a review from a team as a code owner September 18, 2024 07:23
utsabc
utsabc previously approved these changes Sep 19, 2024
Copy link

@yashasvibajpai yashasvibajpai merged commit d40e772 into develop Sep 24, 2024
26 checks passed
@yashasvibajpai yashasvibajpai deleted the feat.shopify.v2 branch September 24, 2024 05:11
const responseV2 = await processEventFromPixel(event);
return responseV2;
}
const webhookEventResponse = await processPixelWebhookEvent(event, metricMetadata, source);
Copy link
Contributor

@vinayteki95 vinayteki95 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishna2020 processPixelWebhookEvent function definition has only 2 arguments. source is not utilised in the function.

  • This doesn't affect the code though!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is getting cleaned up in next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants