-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard shopify to v1 #3665
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3665/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3665 +/- ##
===========================================
+ Coverage 88.69% 88.72% +0.02%
===========================================
Files 594 599 +5
Lines 32413 32639 +226
Branches 7727 7770 +43
===========================================
+ Hits 28750 28960 +210
- Misses 3342 3387 +45
+ Partials 321 292 -29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the requested comments
…to feat.shopify.v2
…ormer into feat.shopify.v2
Quality Gate passedIssues Measures |
const responseV2 = await processEventFromPixel(event); | ||
return responseV2; | ||
} | ||
const webhookEventResponse = await processPixelWebhookEvent(event, metricMetadata, source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishna2020 processPixelWebhookEvent
function definition has only 2 arguments. source
is not utilised in the function.
- This doesn't affect the code though!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is getting cleaned up in next PR
What are the changes introduced in this PR?
What is the related Linear task?
Resolves INT-2511
Please explain the objectives of your changes below
There should not be any breaking changes in the old implementation.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
Source transformations added for the new shopify pixel app.
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.