Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics for braze alias failures #3452

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Jun 10, 2024

What are the changes introduced in this PR?

This PR adds metrics for braze identify flow where errors are observed due missing userId, as braze returns 200 with an error message in response body we want to capture that as metrics

What is the related Linear task?

Resolves INT-2259

@utsabc utsabc requested review from a team as code owners June 10, 2024 06:28
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.02%. Comparing base (b1a0f24) to head (41266f5).
Report is 4 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/braze/util.js 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3452      +/-   ##
===========================================
- Coverage    88.02%   88.02%   -0.01%     
===========================================
  Files          570      570              
  Lines        30773    30795      +22     
  Branches      7351     7361      +10     
===========================================
+ Hits         27089    27107      +18     
- Misses        3349     3380      +31     
+ Partials       335      308      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/v0/destinations/braze/util.js Outdated Show resolved Hide resolved
src/v0/destinations/braze/util.js Outdated Show resolved Hide resolved
src/util/prometheus.js Outdated Show resolved Hide resolved
Copy link

@utsabc utsabc merged commit a39df2b into develop Jun 10, 2024
16 checks passed
@utsabc utsabc deleted the chore.braze-alias-metrics branch June 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants