Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: editing unit test case and removing unnecessary component test for emarsys #3429

Closed
wants to merge 1 commit into from

Conversation

shrouti1507
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners May 30, 2024 05:22
@shrouti1507 shrouti1507 requested review from krishna2020 and Gauravudia and removed request for a team May 30, 2024 05:22
@shrouti1507
Copy link
Contributor Author

As discussed with @krishna2020 we can have component test. Hence closing this PR

@devops-github-rudderstack
Copy link
Contributor

Copy link

@devops-github-rudderstack devops-github-rudderstack deleted the fix.emarsys-test branch August 31, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants