-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logger at integration level #3401
Conversation
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3401/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3401 +/- ##
===========================================
+ Coverage 88.00% 88.03% +0.03%
===========================================
Files 572 574 +2
Lines 30910 31056 +146
Branches 7385 7410 +25
===========================================
+ Hits 27202 27340 +138
- Misses 3398 3405 +7
- Partials 310 311 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
…response logging Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
…ject while logging error Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
chore: add request logs for proxy request Signed-off-by: Sai Sankeerth <[email protected]>
- set level as part of initialisation
- update getLoggerImpl logic by adding switch cases
- add destType in cdkv2 handler - include extra fields in fillExcept logger option
Signed-off-by: Sai Sankeerth <[email protected]>
- remove usage of logError function from services/misc.ts
src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js
Show resolved
Hide resolved
src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js
Outdated
Show resolved
Hide resolved
chore: add stats for gladly API call Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
We are adding structured logger in all flows necessary.
Example of structured log
const logger = structuredLogger()
error
).requestLog
andresponseLog
url
,body
andmethod
of requesturl
,body
andheaders
of responseLOG_LEVEL
towarn
Note
- Like so,
logger.error('My error:', "err")
- As this would generate a log
{level: "error", "logMetadata": {0:"e",1:"r",2:"r"}, message:"My error", ...}
What is the related Linear task?
Resolves INT-2102
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.