Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ga4 proxy test refactor #3071

Closed
wants to merge 21 commits into from
Closed

chore: ga4 proxy test refactor #3071

wants to merge 21 commits into from

Conversation

mihir-4116
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

utsabc and others added 20 commits January 25, 2024 12:50
Added new structure for proxy test scnearios for cm360 also added zod validations as part of tests
…usiness.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…usiness.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* feat: add type definitions for test cases

* fix: update networkHandler for rakuten

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
@mihir-4116 mihir-4116 requested review from sivashanmukh and a team as code owners February 8, 2024 09:18
Copy link
Contributor

coderabbitai bot commented Feb 8, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@mihir-4116 mihir-4116 changed the title chore: ga4 proxy test refactor chore(INT-1483): ga4 proxy test refactor Feb 8, 2024
@mihir-4116 mihir-4116 changed the title chore(INT-1483): ga4 proxy test refactor chore: ga4 proxy test refactor Feb 8, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 93.09623% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 84.70%. Comparing base (de3518f) to head (cf009ae).
Report is 38 commits behind head on develop.

❗ Current head cf009ae differs from pull request most recent head d206a24. Consider uploading reports for the commit d206a24 to get more accurate results

Files Patch % Lines
...ions/the_trade_desk_real_time_conversions/utils.js 91.26% 11 Missing ⚠️
src/cdk/v2/destinations/bluecore/utils.js 90.42% 8 Missing and 1 partial ⚠️
src/types/zodTypes.ts 93.18% 3 Missing ⚠️
src/util/customTransformer.js 0.00% 2 Missing ⚠️
src/util/stats.js 33.33% 2 Missing ⚠️
src/util/customTransformer-v1.js 66.66% 1 Missing ⚠️
src/util/customTransformerFactory.js 75.00% 1 Missing ⚠️
src/util/ivmFactory.js 66.66% 1 Missing ⚠️
...v0/destinations/salesforce_oauth/networkHandler.js 50.00% 1 Missing ⚠️
...c/v0/destinations/the_trade_desk/networkHandler.js 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3071      +/-   ##
===========================================
- Coverage    87.21%   84.70%   -2.51%     
===========================================
  Files          537      494      -43     
  Lines        29244    27274    -1970     
  Branches      6963     6556     -407     
===========================================
- Hits         25504    23102    -2402     
- Misses        3393     3748     +355     
- Partials       347      424      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix.network-handlers to develop February 20, 2024 16:31
@utsabc utsabc requested a review from a team as a code owner February 20, 2024 16:31
@utsabc utsabc requested a review from saikumarrs February 20, 2024 16:31
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mihir-4116 mihir-4116 requested review from a team as code owners February 27, 2024 04:06
@mihir-4116
Copy link
Contributor Author

Closing this pr as too many conflicts are there
created new pr here

@mihir-4116 mihir-4116 closed this Feb 27, 2024
@devops-github-rudderstack devops-github-rudderstack deleted the ga4.refactor-proxy branch May 28, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants