chore(release): pull hotfix-release/v1.53.1 into main #2992

devops-github-rudderstack · 2024-01-16T06:40:13Z

👑 An automated PR

coderabbitai · 2024-01-16T06:40:19Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

…2994) * fix: validate event name to be string before accessing it * update changelog * chore:comment addresed

codecov · 2024-01-16T07:26:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a959d4) 87.28% compared to head (91f74cf) 87.28%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         872      872           
  Lines       29500    29505    +5     
  Branches     6865     6869    +4     
=======================================
+ Hits        25749    25754    +5     
  Misses       3405     3405           
  Partials      346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anantjain45823

Approved for klaviyo

src/v0/destinations/klaviyo/transform.js

krishna2020 · 2024-01-16T08:02:50Z

test/integrations/destinations/mp/processor/data.ts

@@ -94,7 +94,7 @@ export const data = [
                JSON: {},
                JSON_ARRAY: {
                  batch:
-                    '[{"event":"Loaded a Page","properties":{"ip":"0.0.0.0","campaign_id":"test_name","$user_id":"hjikl","$current_url":"https://docs.rudderstack.com/destinations/mixpanel","$screen_dpi":2,"mp_lib":"RudderLabs JavaScript SDK","$app_build_number":"1.0.0","$app_version_string":"1.0.5","$insert_id":"dd266c67-9199-4a52-ba32-f46ddde67312","token":"dummyApiKey","distinct_id":"hjikl","time":1579847342,"utm_campaign":"test_name","utm_source":"rudder","utm_medium":"test_medium","utm_term":"test_tem","utm_content":"test_content","utm_test":"test","utm_keyword":"test_keyword","name":"Contact Us","$browser":"Chrome","$browser_version":"79.0.3945.117"}}]',


@Gauravudia Did we checked whether the change of time precision affects any use-case apart from ordering ?
Is this field accessible by mixpanel user to build some reports ?

This field is accessible in Filter section in mixpanel Reports.

src/v0/destinations/klaviyo/transform.js

Co-authored-by: Krishna Chaitanya <[email protected]>

sonarqubecloud · 2024-01-16T11:01:55Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Gauravudia and others added 2 commits January 16, 2024 11:59

fix: mixpanel timestamp in ms (#2990)

0da63a4

chore(release): 1.53.1

ae9249d

devops-github-rudderstack requested review from a team and sivashanmukh as code owners January 16, 2024 06:40

devops-github-rudderstack requested review from anantjain45823 and sandeepdsvs January 16, 2024 06:40

fix: klaviyo: Event validation to be string before operating on it (#…

a7a7c60

…2994) * fix: validate event name to be string before accessing it * update changelog * chore:comment addresed

anantjain45823 previously approved these changes Jan 16, 2024

View reviewed changes

krishna2020 reviewed Jan 16, 2024

View reviewed changes

src/v0/destinations/klaviyo/transform.js Show resolved Hide resolved

krishna2020 reviewed Jan 16, 2024

View reviewed changes

chore: allowing message with undefined event

13dd5ff

anantjain45823 dismissed their stale review via 13dd5ff January 16, 2024 08:18

shrouti1507 requested a review from krishna2020 January 16, 2024 09:39

Gauravudia previously approved these changes Jan 16, 2024

View reviewed changes

krishna2020 reviewed Jan 16, 2024

View reviewed changes

src/v0/destinations/klaviyo/transform.js Outdated Show resolved Hide resolved

krishna2020 reviewed Jan 16, 2024

View reviewed changes

src/v0/destinations/klaviyo/transform.js Outdated Show resolved Hide resolved

anantjain45823 dismissed Gauravudia’s stale review via aa948be January 16, 2024 10:36

anantjain45823 and others added 3 commits January 16, 2024 16:06

Update src/v0/destinations/klaviyo/transform.js

aa948be

Co-authored-by: Krishna Chaitanya <[email protected]>

Update src/v0/destinations/klaviyo/transform.js

7f0ffdd

Co-authored-by: Krishna Chaitanya <[email protected]>

fix: editing component test of klaviyo

91f74cf

shrouti1507 requested a review from krishna2020 January 16, 2024 10:56

krishna2020 closed this Jan 22, 2024

devops-github-rudderstack deleted the hotfix-release/v1.53.1 branch April 17, 2024 01:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): pull hotfix-release/v1.53.1 into main #2992

chore(release): pull hotfix-release/v1.53.1 into main #2992

devops-github-rudderstack commented Jan 16, 2024

coderabbitai bot commented Jan 16, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

codecov bot commented Jan 16, 2024 •

edited

Loading

anantjain45823 left a comment

krishna2020 Jan 16, 2024

Gauravudia Jan 16, 2024

sonarqubecloud bot commented Jan 16, 2024

chore(release): pull hotfix-release/v1.53.1 into main #2992

chore(release): pull hotfix-release/v1.53.1 into main #2992

Conversation

devops-github-rudderstack commented Jan 16, 2024

coderabbitai bot commented Jan 16, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

codecov bot commented Jan 16, 2024 • edited Loading

Codecov Report

anantjain45823 left a comment

Choose a reason for hiding this comment

krishna2020 Jan 16, 2024

Choose a reason for hiding this comment

Gauravudia Jan 16, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 16, 2024

Quality Gate passed

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Jan 16, 2024 •

edited

Loading