Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard new tiktok version events 2.0 #2961

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Dec 28, 2023

What are the changes introduced in this PR?

Onboarding new API for tiktok_ads doc

What is the related Linear task?

Resolves INT-1103

Please explain the objectives of your changes below

Tiktok has introduces events 2.0 doc and deprecating event 1.0 by H2 2024.
Hence we are updating the our tiktok_ads integration as well with options in UI to use event1.0 or events2.0 .
Since the change is at endpoint and payload schema with completely different batching logic as well, I have introduced a transformV2.js to handle events 2.0 transformation including both router and processor

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

There are some schema changes in which tiktok accepts the data, endpoint and batching logic is changed as well

Any new dependencies introduced with this change?

Release intg-config with option to choose from event1.0 or event 2.0

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes? -> 11 files due mocking

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link
Contributor

coderabbitai bot commented Dec 28, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f6652b5) 87.18% compared to head (70050b4) 87.23%.
Report is 5 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/tiktok_ads/transformV2.js 98.24% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2961      +/-   ##
===========================================
+ Coverage    87.18%   87.23%   +0.05%     
===========================================
  Files          529      530       +1     
  Lines        28659    28802     +143     
  Branches      6824     6859      +35     
===========================================
+ Hits         24985    25126     +141     
- Misses        3340     3342       +2     
  Partials       334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai
Copy link
Contributor

Please update the template @anantjain45823 😄

Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked overall not specific destination functionality

src/v0/destinations/tiktok_ads/util.js Outdated Show resolved Hide resolved
src/v0/destinations/tiktok_ads/transformV2.js Outdated Show resolved Hide resolved
src/v0/destinations/tiktok_ads/transformV2.js Outdated Show resolved Hide resolved
src/v0/destinations/tiktok_ads/transformV2.test.js Outdated Show resolved Hide resolved
koladilip
koladilip previously approved these changes Jan 17, 2024
Copy link

@anantjain45823 anantjain45823 merged commit 0fca088 into develop Jan 18, 2024
15 checks passed
@anantjain45823 anantjain45823 deleted the feat.tiktok2.0 branch January 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants