-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard new tiktok version events 2.0 #2961
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2961 +/- ##
===========================================
+ Coverage 87.18% 87.23% +0.05%
===========================================
Files 529 530 +1
Lines 28659 28802 +143
Branches 6824 6859 +35
===========================================
+ Hits 24985 25126 +141
- Misses 3340 3342 +2
Partials 334 334 ☔ View full report in Codecov by Sentry. |
Please update the template @anantjain45823 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked overall not specific destination functionality
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What are the changes introduced in this PR?
Onboarding new API for tiktok_ads doc
What is the related Linear task?
Resolves INT-1103
Please explain the objectives of your changes below
Tiktok has introduces events 2.0 doc and deprecating event 1.0 by H2 2024.
Hence we are updating the our tiktok_ads integration as well with options in UI to use event1.0 or events2.0 .
Since the change is at endpoint and payload schema with completely different batching logic as well, I have introduced a transformV2.js to handle events 2.0 transformation including both router and processor
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
There are some schema changes in which tiktok accepts the data, endpoint and batching logic is changed as well
Any new dependencies introduced with this change?
Release intg-config with option to choose from event1.0 or event 2.0
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes? -> 11 files due mocking
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.