Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.51.0 into main #2878

Merged
merged 23 commits into from
Dec 6, 2023
Merged

chore(release): pull release/v1.51.0 into main #2878

merged 23 commits into from
Dec 6, 2023

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

aashishmalik and others added 23 commits November 14, 2023 14:52
* feat: onboard gladly destination

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* fix: package.json changes

* chore: added utility tests

* chore: added gladly router and processor tests

* chore: added gladly rETL tests

* fix: sonar code smell

* chore: code review changes
chore: add date mock to fix timestamp validation
* feat: initial commit

* feat: making sure existing functionality is intact

* fix: edits for exclusion keys

* fix: edits for supporting property paths

* fix: delete wrong test case

* fix: test cases

* fix: removed unnecessary code

* fix: adding unit test cases for trimTraits

* fix: changing the order of priority in property mapping

* fix: edited distinct id logic

* fix: small edit

* fix: review comments addressed

* fix: adding dedicated mappingJson for setOnce

* fix: adding all the fields to the dedicated json

* fix: addressing review comments

* feat: review comments addressed
* feat: update facebook destinations API version to v18.0

* feat: updated fb_pixel tests to pick version dynamically from config.js

* feat: updated fb tests to pick version dynamically from config.js

* feat: updated fb_custom_audience tests to pick version dynamically from config.js
* feat: cm360 transformerproxy, V1 features.json update

* feat: add support for both v0,v1 in handler for old server support

* fix: addressed comments

* chore: added tests for V1 too
* fix: encode &, < and > to html counterparts in adobe

* fix: use encodeurl on url valuez
* fix: timestamp microseconds input cm360

* feat: batching in cm360

* chore: addressed comments

* chore: addressed comments

* fix: return aborted inside cath block

* feat: update batching partial events

* feat: update batching partial events

* feat: update batching partial events

* feat: update batching partial events

* chore: removed hardcoded response

* feat: added new error class

* chore: develop merge

* feat: handle metadata as obj

* feat: handle metadata as obj

* chore: removed commented code

* fix: merged develop

* fix: merged develop

* chore: added tests for batching

* chore: added tests for batching
* feat: marketo: migrate config fields and fix test cases

* Update destination_config.json

* chore: fix test cases

* Update utils.js

* Update destinationCanonicalNames.js

* Update cdkV2Integration.ts

* Update index.js

* Update am_input.json

* Update am_output.json

* Update am_input.json

* Update am_output.json

* Update data.ts

* Update am_input.json

* Update data.ts

* Update data.ts

* chore: small fix
Copy link
Contributor

coderabbitai bot commented Dec 6, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (e04cedd) 87.30% compared to head (669ed41) 87.19%.

Files Patch % Lines
...v1/destinations/campaign_manager/networkHandler.js 87.50% 6 Missing and 1 partial ⚠️
src/v0/destinations/active_campaign/transform.js 16.66% 5 Missing ⚠️
src/v0/destinations/active_campaign/util.js 16.66% 4 Missing and 1 partial ⚠️
src/controllers/destination.ts 76.92% 3 Missing ⚠️
src/v0/destinations/campaign_manager/transform.js 95.91% 2 Missing ⚠️
src/controllers/regulation.ts 75.00% 1 Missing ⚠️
src/services/comparator.ts 66.66% 1 Missing ⚠️
src/services/destination/postTransformation.ts 80.00% 1 Missing ⚠️
src/services/source/nativeIntegration.ts 80.00% 1 Missing ⚠️
src/v0/destinations/adobe_analytics/utils.js 83.33% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2878      +/-   ##
==========================================
- Coverage   87.30%   87.19%   -0.12%     
==========================================
  Files         776      776              
  Lines       29992    28942    -1050     
  Branches     7245     6788     -457     
==========================================
- Hits        26184    25235     -949     
+ Misses       3455     3365      -90     
+ Partials      353      342      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utsabc utsabc merged commit 623cd5d into main Dec 6, 2023
18 of 20 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the release/v1.51.0 branch December 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.