-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dm): added stats during various stages of event schema validation #2870
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2870 +/- ##
===========================================
+ Coverage 87.11% 87.18% +0.07%
===========================================
Files 768 776 +8
Lines 28653 28938 +285
Branches 6726 6787 +61
===========================================
+ Hits 24960 25231 +271
- Misses 3350 3365 +15
+ Partials 343 342 -1 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description of the change
We have now started using
useClones: false
for the tracking plan when we store it in the local node cache. This allows for the same reference to be used everytime and don't create a replica of the stored value everytime.This has massively speed up the performance for us when the tracking plan contains a lot of events and it needs to be copied everytime it gets fetched from the cache.
Fixes: DAT-686
Type of change
Related issues
Checklists
Development
Code review