Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard Adobe Analytics to transformer proxy #2858

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Nov 30, 2023

What are the changes introduced in this PR?

Resolves INT-1043
We are onboarding Adobe Analytics to transformer proxy.

Please explain the objectives of your changes below

We have moved Adobe to proxy as Adobe rejects the incorrect payloads with a 200 code, so by looking at the response returned, we need to figure out the reason of failure.

Type of change

If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.

  • Existing capabilities/behavior
    No visibility of failing payloads and the associated reason.

  • New capabilities/behavior
    We will see a reason in proc-errors table now for the failure.

If the pull request is a new feature,

Any technical or performance related pointers to consider with the change?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

N/A

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

N/A


Developer checklist

  • No breaking changes are being introduced.

  • Are all related docs linked with the PR?

  • Are all changes manually tested?

  • Does this change require any documentation changes?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Nov 30, 2023
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36d3f25) 87.22% compared to head (ecc7322) 87.24%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2858      +/-   ##
===========================================
+ Coverage    87.22%   87.24%   +0.02%     
===========================================
  Files          787      790       +3     
  Lines        29163    29190      +27     
  Branches      6826     6830       +4     
===========================================
+ Hits         25438    25468      +30     
+ Misses        3380     3377       -3     
  Partials       345      345              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai marked this pull request as ready for review December 5, 2023 04:17
@yashasvibajpai yashasvibajpai requested review from a team and sivashanmukh as code owners December 5, 2023 04:17
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yashasvibajpai yashasvibajpai merged commit e8f2d1a into develop Dec 11, 2023
23 checks passed
@yashasvibajpai yashasvibajpai deleted the chore.adobe.to.proxy branch December 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants