-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: onboard Adobe Analytics to transformer proxy #2858
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2858 +/- ##
===========================================
+ Coverage 87.22% 87.24% +0.02%
===========================================
Files 787 790 +3
Lines 29163 29190 +27
Branches 6826 6830 +4
===========================================
+ Hits 25438 25468 +30
+ Misses 3380 3377 -3
Partials 345 345 ☔ View full report in Codecov by Sentry. |
test/integrations/destinations/adobe_analytics/dataDelivery/data.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/adobe_analytics/dataDelivery/data.ts
Outdated
Show resolved
Hide resolved
test/integrations/destinations/adobe_analytics/dataDelivery/data.ts
Outdated
Show resolved
Hide resolved
… test-case Signed-off-by: Sai Sankeerth <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
What are the changes introduced in this PR?
Resolves INT-1043
We are onboarding Adobe Analytics to transformer proxy.
Please explain the objectives of your changes below
We have moved Adobe to proxy as Adobe rejects the incorrect payloads with a 200 code, so by looking at the response returned, we need to figure out the reason of failure.
Type of change
If the pull request is a bug-fix, enhancement or a refactor, please fill in the details on the changes made.
Existing capabilities/behavior
No visibility of failing payloads and the associated reason.
New capabilities/behavior
We will see a reason in proc-errors table now for the failure.
If the pull request is a new feature,
Any technical or performance related pointers to consider with the change?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.
N/A
If multiple linear tasks are associated with the PR changes, please elaborate on the reason:
N/A
Developer checklist
No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.