Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add new PR template #2849

Closed
wants to merge 8 commits into from
Closed

chore: add new PR template #2849

wants to merge 8 commits into from

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Nov 23, 2023 •
edited by coderabbitai bot
Loading

Description of the change

We are adding new PR template

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Summary by CodeRabbit

  • Documentation
    • Introduced a pull request template to standardize the description of code changes for developers and reviewers.

aashishmalik and others added 6 commits November 14, 2023 14:52
@aashishmalik
chore(release): pull main into develop post release v1.50.0 (#2827)
a6f7d13
@utsabc
chore: update import and export names, default new routes (#2810)
06c6503
@mihir-4116
feat(INT-305): onboard gladly destination (#2786)
ff80b88 
* feat: onboard gladly destination

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* chore: code review changes

* fix: package.json changes

* chore: added utility tests

* chore: added gladly router and processor tests

* chore: added gladly rETL tests

* fix: sonar code smell

* chore: code review changes
@abhimanyubabbar
chore: capture correct status code on faas pod time out (#2831)
e5f8714
@sandeepdsvs
chore: add date mock to fix timestamp validation in tests (#2844)
5c63d2c 
chore: add date mock to fix timestamp validation
@yashasvibajpai
chore: add new PR template
e1cfc38
@yashasvibajpai yashasvibajpai self-assigned this Nov 23, 2023
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners November 23, 2023 10:15
@shrouti1507
feat: mixpanel set once feature onboard (#2820)
9eda50e 
* feat: initial commit

* feat: making sure existing functionality is intact

* fix: edits for exclusion keys

* fix: edits for supporting property paths

* fix: delete wrong test case

* fix: test cases

* fix: removed unnecessary code

* fix: adding unit test cases for trimTraits

* fix: changing the order of priority in property mapping

* fix: edited distinct id logic

* fix: small edit

* fix: review comments addressed

* fix: adding dedicated mappingJson for setOnce

* fix: adding all the fields to the dedicated json

* fix: addressing review comments

* feat: review comments addressed
utsabc
utsabc previously approved these changes Nov 27, 2023
View reviewed changes
@yashasvibajpai yashasvibajpai changed the base branch from main to develop November 27, 2023 08:59
@yashasvibajpai yashasvibajpai dismissed utsabc’s stale review November 27, 2023 08:59

The base branch was changed.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2023 •
edited
Loading

Walkthrough

The pull request introduces a structured template for documenting pull requests, ensuring that contributors provide comprehensive details about their code changes. This template will guide developers and reviewers through the necessary steps to validate and understand the changes before merging, including the purpose, type of change, technical considerations, dependencies, and a thorough checklist.

Changes

File Path Change Summary
.github/pull_request_template.md Added a pull request template with sections for objectives, change type, technical considerations, dependencies, and checklists for developers and reviewers.

Assessment against linked issues

Objective Addressed Explanation
Checking in latest GATransform artifacts under dipanjan branch of rud… (#1) ❓ It is unclear from the summary provided whether the specific artifacts for GATransform have been included in this pull request.

Poem

In the land of code where the pull requests flow,
A template emerges to guide us just so.
🐇 With each careful check, we merge with delight,
Ensuring our code takes off in flight. ✈️

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@yashasvibajpai yashasvibajpai changed the base branch from develop to main November 27, 2023 09:03
@yashasvibajpai yashasvibajpai requested review from a team as code owners November 27, 2023 09:03
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yashasvibajpai yashasvibajpai deleted the chore.pr.template branch December 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc left review comments

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@chandumlg chandumlg Awaiting requested review from chandumlg chandumlg is a code owner automatically assigned from rudderlabs/integrations

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 is a code owner automatically assigned from rudderlabs/integrations

Assignees

@yashasvibajpai yashasvibajpai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yashasvibajpai @utsabc @aashishmalik @mihir-4116 @abhimanyubabbar @sandeepdsvs @shrouti1507