-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): pull release/v1.49.0 into main #2797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: refactoring amplitude using optional chaining * test cases added for source endpoint * chore: minor fixes * chore: comment addressed * chore: solve sonar issues 1 * chore: solve sonar issues 2 * chore: solve sonar issues 3 * chore: resolve sonar hotspot * chore: resolve sonar * chore: solve sonar issues 4 * chore: small fixes and test cases addition * chore: small fixes and test cases addition+1 * chore: merge develop issue fix * Update src/v0/destinations/am/transform.js Co-authored-by: Sankeerth <[email protected]> * Update src/v0/destinations/am/transform.js Co-authored-by: Sankeerth <[email protected]> * chore: addressed comments * chore: reduce cognitive complexity+1 * chore: add test cases * chore: addressed comments * chore: addressed comments+1 * chore: comments addressed * chore: comments addressed+1 * chore: resolve sonar * chore: comments addressed+2 * sonarcloud fix+1 --------- Co-authored-by: Sai Sankeerth <[email protected]> Co-authored-by: Sankeerth <[email protected]>
* feat: add new destination tiktok_audience * remove log * refactor code * chore: refactor workflows * add test cases * chore: refactore code * refactor code and add negative test case --------- Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: mihir-4116 <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]>
…er (#2780) * fix: allow support for full url from UI in freshsales * fix: allow support for full url from UI in freshmarketer * fix: tests * fix: testsx2
* chore: update release owner * chore: update release-owners
* refactor: revenuecat source code * chore: refactor, address comments
…#2796) * fix: add check to remove null and undefined properties before sending * chore: fix test
* chore(klaviyo): remove error notifier * fix(freshsales): stringify event before lowercase * fix(customerio): convert eventName to string for truncate * fix: add validation for event Name type and update function name * fix: remove unrequired validation
devops-github-rudderstack
requested review from
a team and
sivashanmukh
as code owners
November 6, 2023 10:17
devops-github-rudderstack
requested review from
yashasvibajpai and
saikumarrs
November 6, 2023 10:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
- Coverage 87.25% 87.18% -0.07%
==========================================
Files 769 771 +2
Lines 28709 28510 -199
Branches 6784 6658 -126
==========================================
- Hits 25049 24857 -192
+ Misses 3322 3316 -6
+ Partials 338 337 -1
☔ View full report in Codecov by Sentry. |
krishna2020
reviewed
Nov 6, 2023
Kudos, SonarCloud Quality Gate passed! |
krishna2020
approved these changes
Nov 7, 2023
ujjwal-ab
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR