Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull release/v1.46.0 into main #2741

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

mihir-4116 and others added 12 commits October 12, 2023 18:06
* feat: onboard source ortto

* fix: add mocking for anonymousId

* fix: add timestamp mapping

* fix: correct event mapping

* feat: update mapping and refactor code

* chore: improve test coverage
* feat: facebook pixel audit refactoring

* feat: facebook pixel audit refactoring

* feat: updated optional chaining and fixed a minor bug
* feat: mixpanel gzip support for import endpoint

* feat: remove gzipping in transformer

* fix: test cases
* feat: enhancement: snapchat_conversion add new fields

* fix: sinarcloud issue
* fix: fix getFbGenderVal function

* fix: review comments addressed

* fix: putting back the formatting as it was
* feat: onboard facebook_conversions destination

* feat: onboard facebook_conversions destination

* feat: added support for app events

* feat: renamed FBAppEventsConfig to FBCAppEventsConfig

* feat: add Config.actionSource as fallback for action_source

* feat: use both content_name and contentName to populate destKey content_name

* feat: reduced cognitive complexity

* feat: added tests

* feat: reduced deduplication

* feat: add router tests and moved common functions to root utils folder

* feat: add mapping config for payment info entered and product added to wishlist

* feat: add tests for AddPaymentInfo and AddToWishlist

* feat: addressed review comments

* feat: moved networkHandler to fb common utils

* feat: resolved code smells
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c9e8bdb) 87.56% compared to head (17cd1f8) 87.28%.

❗ Current head 17cd1f8 differs from pull request most recent head be4c410. Consider uploading reports for the commit be4c410 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   87.56%   87.28%   -0.28%     
==========================================
  Files         646      646              
  Lines       29330    28574     -756     
  Branches     7127     6785     -342     
==========================================
- Hits        25683    24942     -741     
+ Misses       3312     3303       -9     
+ Partials      335      329       -6     
Files Coverage Δ
src/constants/destinationCanonicalNames.js 100.00% <ø> (ø)
...estinations/facebook_conversions/networkHandler.js 100.00% <100.00%> (ø)
src/v0/destinations/facebook_pixel/config.js 100.00% <100.00%> (ø)
...c/v0/destinations/facebook_pixel/networkHandler.js 100.00% <100.00%> (ø)
src/v0/destinations/facebook_pixel/transform.js 98.01% <100.00%> (+1.18%) ⬆️
src/v0/destinations/mp/util.js 99.20% <100.00%> (-0.09%) ⬇️
src/v0/destinations/snapchat_conversion/config.js 100.00% <ø> (ø)
...c/v0/destinations/snapchat_conversion/transform.js 92.21% <100.00%> (-1.82%) ⬇️
src/v0/sources/ortto/transform.js 100.00% <100.00%> (ø)
src/v0/util/facebookUtils/networkHandler.js 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aashishmalik and others added 3 commits October 18, 2023 12:39
* fix: fixed hub not found error in helm charts

* fix: replaced hub with gh
…sent (#2742)

feat: setting empty string as default if app event params are not sent in event
* fix: update duplicate verions in github release

* fix: added debug for releaser
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 merged commit 15c51ca into main Oct 18, 2023
15 of 16 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the release/v1.46.0 branch October 18, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.