fix(dm): updated the stats definition for the tracking plan service #2658

abhimanyubabbar · 2023-09-26T05:16:09Z

Description of the change

As part of this hotfix, we are fixing the definition of couple of critical stats for tracking plan in the prometheus.js file to align with the stat fired from the service. The consequence of the issue is that we have critical P0 alerts which are not getting fired for the DM team.

Ticket: https://linear.app/rudderstack/issue/DAT-404/hotfix-for-the-user-transformer-service

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

koladilip · 2023-09-26T05:50:44Z

src/util/prometheus.js

@@ -614,18 +614,6 @@ class Prometheus {
          'k8_namespace',
        ],
      },
-      {
-        name: 'user_transform_function_latency',


rudder-transformer/src/legacy/router.js

Line 631 in e7dbd2c

stats.timing('user_transform_function_latency', userFuncStartTime, {

this is referred here so it might cause issue if someone is using legacy routes.

It's legacy router and not used anymore. We plan to remove this file eventually.

what about vpc customers? may be we won't support UTs for vpc customers right?

codecov · 2023-09-26T07:02:29Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2778ed7) 86.89% compared to head (84083aa) 86.89%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2658   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         604      604           
  Lines       28117    28117           
  Branches     6694     6694           
=======================================
  Hits        24431    24431           
  Misses       3353     3353           
  Partials      333      333