Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cm360 matchId fixed #2642

Closed
wants to merge 4 commits into from
Closed

fix: cm360 matchId fixed #2642

wants to merge 4 commits into from

Conversation

aashishmalik
Copy link
Contributor

Description of the change

cm360 matchId fixed

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aashishmalik aashishmalik changed the base branch from develop to main September 21, 2023 12:22
@aashishmalik aashishmalik changed the base branch from main to develop September 21, 2023 12:22
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (884f0f6) 87.00% compared to head (daa48f9) 86.94%.
Report is 7 commits behind head on develop.

❗ Current head daa48f9 differs from pull request most recent head a04af93. Consider uploading reports for the commit a04af93 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2642      +/-   ##
===========================================
- Coverage    87.00%   86.94%   -0.06%     
===========================================
  Files          604      604              
  Lines        28407    28167     -240     
  Branches      6800     6702      -98     
===========================================
- Hits         24715    24490     -225     
+ Misses        3359     3344      -15     
  Partials       333      333              
Files Changed Coverage Δ
src/v0/destinations/campaign_manager/transform.js 92.85% <100.00%> (+5.47%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@ItsSudip ItsSudip deleted the fix.exinity-matchId branch December 13, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants