Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facebook_conversions_api): updated fb_pixel to support facebook_conversions_api #2641

Closed
wants to merge 8 commits into from

Conversation

sandeepdsvs
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sandeepdsvs sandeepdsvs requested review from a team as code owners September 21, 2023 11:50
@sandeepdsvs sandeepdsvs self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (deddae1) 86.93% compared to head (0a584c9) 86.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2641      +/-   ##
===========================================
- Coverage    86.93%   86.89%   -0.04%     
===========================================
  Files          605      605              
  Lines        28167    28188      +21     
  Branches      6703     6711       +8     
===========================================
+ Hits         24486    24493       +7     
- Misses        3348     3359      +11     
- Partials       333      336       +3     
Files Coverage Δ
src/constants/destinationCanonicalNames.js 100.00% <ø> (ø)
src/v0/destinations/facebook_pixel/config.js 100.00% <ø> (ø)
src/v0/destinations/facebook_pixel/transform.js 92.78% <80.00%> (-0.84%) ⬇️
src/v0/destinations/facebook_pixel/utils.js 92.12% <25.00%> (-5.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs
Copy link
Contributor Author

Updates tests and add destination documentation links.

@sandeepdsvs sandeepdsvs changed the title feat(facebook_datasets): updated fb_pixel to support facebook_datasets feat(facebook_conversions_api): updated fb_pixel to support facebook_conversions_api Sep 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

48.8% 48.8% Coverage
0.0% 0.0% Duplication

@sandeepdsvs
Copy link
Contributor Author

closing this PR and replacing this with this PR

@devops-github-rudderstack devops-github-rudderstack deleted the feat.fb_datasets branch December 28, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant