feat: add axios mocking to component test-suite #2638

sanpj2292 · 2023-09-20T13:12:11Z

Description of the change

Resolves INT-371

Axios mocking capability in component test-suite

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

Signed-off-by: Sai Sankeerth <[email protected]>

test/integrations/component.test.ts

- add mocks for other component test included destinations - add capability to generate network mocks - add command to generate network mocks Signed-off-by: Sai Sankeerth <[email protected]>

codecov · 2023-09-21T15:28:55Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (deddae1) 86.93% compared to head (e7e9b29) 86.95%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2638      +/-   ##
===========================================
+ Coverage    86.93%   86.95%   +0.02%     
===========================================
  Files          605      635      +30     
  Lines        28167    28297     +130     
  Branches      6703     6713      +10     
===========================================
+ Hits         24486    24606     +120     
- Misses        3348     3357       +9     
- Partials       333      334       +1

Files	Coverage Δ
src/v0/destinations/canny/util.js	`81.81% <100.00%> (ø)`
src/v0/destinations/yahoo_dsp/util.js	`90.00% <100.00%> (ø)`
...tegrations/destinations/active_campaign/network.ts	`100.00% <100.00%> (ø)`
...t/integrations/destinations/af/deleteUsers/data.ts	`100.00% <100.00%> (ø)`
test/integrations/destinations/af/network.ts	`100.00% <100.00%> (ø)`
...t/integrations/destinations/am/deleteUsers/data.ts	`100.00% <100.00%> (ø)`
test/integrations/destinations/am/network.ts	`100.00% <100.00%> (ø)`
...ntegrations/destinations/braze/deleteUsers/data.ts	`100.00% <100.00%> (ø)`
test/integrations/destinations/braze/network.ts	`100.00% <100.00%> (ø)`
test/integrations/destinations/canny/data.ts	`100.00% <ø> (ø)`
... and 29 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sai Sankeerth <[email protected]>

…to feat.add-comp-test-axios-mocking

Signed-off-by: Sai Sankeerth <[email protected]>

sonarqubecloud · 2023-09-28T03:34:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

91.7% Coverage
0.0% Duplication

* fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Sudip Paul <[email protected]> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <[email protected]> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <[email protected]> Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: Sudip Paul <[email protected]> Co-authored-by: Sanjay <[email protected]> Co-authored-by: Siva Shanmukh Vetcha <[email protected]> Co-authored-by: Ujjwal Abhishek <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: Sankeerth <[email protected]> Co-authored-by: AASHISH MALIK <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Jayachand <[email protected]> Co-authored-by: Anant Jain <[email protected]>

* fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder * chore(release): pull release/v1.44.0 into main (#2672) * fix(mixpanel): batch event ordering (#2608) * fix: bqstream event ordering fix (#2624) * fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest * fix: use promise for prompts in personalize create tracking script (#2635) * fix(snyk): snyk updated versions merged to oen pr * chore: add ttl values for cache (#2593) * fix(hubspot): add validation for hubspotEvents (#2643) * fix: add optional chaining for error message in network handler of Intercom (#2648) fix bugsnag issue * fix(snyk): removed the new added dependencies * fix(snyk): removed aws-sdk dependency * feat: add circular reference check in flattern json (#2650) * chore: update fb_error message for invalid type of property value (#2656) fix: fb_error message for invalid type of property value * feat(iterable): user deletion support (#2621) * feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments * feat(gaec): partial failures handling (#2631) * chore: partial failure handling * chore: code review changes * chore: move unit tests to correct place for mssql and postgres (#2657) * chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const * feat: add axios mocking to component test-suite (#2638) * feat: tslint rules enable (#2604) * feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts * fix: add auth status inactive category handling to GA in userDeletion flow (#2669) * fix: refactor adjust using optional chaining (#2671) fix: refactor adj using opitonal chaining * chore(release): pull main into develop post release v1.43.1 (#2662) * fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Sudip Paul <[email protected]> * chore(release): 1.44.0 * feat(ga4): added support of filter user traits (#2679) * fix: add optional chaining for traits (#2677) * fix: add optional chaing for traits * update changelog * feat: geolocation support for python transformations (#2678) * feat: geolocation support for python transformations * chore: updating changelog --------- Co-authored-by: Anant Jain <[email protected]> * update changelog * Update CHANGELOG.md --------- Co-authored-by: Gauravudia <[email protected]> Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: Sudip Paul <[email protected]> Co-authored-by: Sanjay <[email protected]> Co-authored-by: Siva Shanmukh Vetcha <[email protected]> Co-authored-by: Ujjwal Abhishek <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: Sankeerth <[email protected]> Co-authored-by: AASHISH MALIK <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Jayachand <[email protected]> Co-authored-by: Anant Jain <[email protected]> --------- Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Sudip Paul <[email protected]> Co-authored-by: devops-github-rudderstack <[email protected]> Co-authored-by: Gauravudia <[email protected]> Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: Dilip Kola <[email protected]> Co-authored-by: Sanjay <[email protected]> Co-authored-by: Siva Shanmukh Vetcha <[email protected]> Co-authored-by: Ujjwal Abhishek <[email protected]> Co-authored-by: Sankeerth <[email protected]> Co-authored-by: AASHISH MALIK <[email protected]> Co-authored-by: Jayachand <[email protected]>

feat: add axios mocking to component test-suite

b179787

Signed-off-by: Sai Sankeerth <[email protected]>

sanpj2292 requested review from sivashanmukh and a team as code owners September 20, 2023 13:12

fix: mock capability extension in component test suite for canny

cacb61d

ItsSudip previously approved these changes Sep 21, 2023

View reviewed changes

test/integrations/component.test.ts Outdated Show resolved Hide resolved

koladilip reviewed Sep 21, 2023

View reviewed changes

test/integrations/component.test.ts Outdated Show resolved Hide resolved

koladilip previously approved these changes Sep 21, 2023

View reviewed changes

test/integrations/component.test.ts Outdated Show resolved Hide resolved

fix: axios network mocking

ff3c3e5

- add mocks for other component test included destinations - add capability to generate network mocks - add command to generate network mocks Signed-off-by: Sai Sankeerth <[email protected]>

sanpj2292 dismissed stale reviews from koladilip and ItsSudip via ff3c3e5 September 21, 2023 15:23

sanpj2292 requested review from ItsSudip and koladilip September 21, 2023 16:26

Sai Sankeerth and others added 3 commits September 21, 2023 22:03

fix: remove unnecessary default value

d8e54aa

Signed-off-by: Sai Sankeerth <[email protected]>

Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…

e7cfdf3

…to feat.add-comp-test-axios-mocking

feat: use axios-mock-adapter for mocking axios requests (#2647)

53a9b5e

sanpj2292 requested review from a team as code owners September 27, 2023 11:03

Merge branch 'develop' of github.com:rudderlabs/rudder-transformer in…

92a56dc

…to feat.add-comp-test-axios-mocking

koladilip previously approved these changes Sep 27, 2023

View reviewed changes

fix: clean-up pardot, optimizely_fullstack

e7e9b29

Signed-off-by: Sai Sankeerth <[email protected]>

sanpj2292 dismissed koladilip’s stale review via e7e9b29 September 28, 2023 03:26

ItsSudip approved these changes Sep 28, 2023

View reviewed changes

sanpj2292 requested a review from koladilip September 28, 2023 04:45

sanpj2292 self-assigned this Sep 28, 2023

koladilip approved these changes Sep 28, 2023

View reviewed changes

sanpj2292 merged commit 100c808 into develop Sep 28, 2023
14 checks passed

sanpj2292 deleted the feat.add-comp-test-axios-mocking branch September 28, 2023 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add axios mocking to component test-suite #2638

feat: add axios mocking to component test-suite #2638

sanpj2292 commented Sep 20, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading

sonarqubecloud bot commented Sep 28, 2023

feat: add axios mocking to component test-suite #2638

feat: add axios mocking to component test-suite #2638

Conversation

sanpj2292 commented Sep 20, 2023 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Sep 28, 2023

sanpj2292 commented Sep 20, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading