Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed prod image build runs #2637

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

krishna2020
Copy link
Collaborator

Description of the change

To fix the two images - :latest, :<version> for production deployment

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (884f0f6) 87.00% compared to head (6b5914d) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   87.00%   86.89%   -0.12%     
==========================================
  Files         604      603       -1     
  Lines       28407    28141     -266     
  Branches     6800     6698     -102     
==========================================
- Hits        24715    24452     -263     
+ Misses       3359     3356       -3     
  Partials      333      333              

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishna2020 krishna2020 marked this pull request as ready for review September 20, 2023 12:42
@krishna2020 krishna2020 requested review from sivashanmukh and a team as code owners September 20, 2023 12:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@krishna2020 krishna2020 merged commit c200ef5 into main Sep 22, 2023
17 of 18 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the chore.correct.image.build branch December 21, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants