Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve conflicts #2622

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: resolve conflicts #2622

merged 2 commits into from
Sep 18, 2023

Conversation

shrouti1507
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners September 18, 2023 06:21
@shrouti1507 shrouti1507 requested review from krishna2020 and sandeepdsvs and removed request for a team September 18, 2023 06:21
@shrouti1507 shrouti1507 merged commit dbb06ac into fix.bqstream-event-order Sep 18, 2023
6 checks passed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@devops-github-rudderstack devops-github-rudderstack deleted the fixing-pr-changes branch December 19, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

@krishna2020 krishna2020 Awaiting requested review from krishna2020 krishna2020 was automatically assigned from rudderlabs/integrations

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs was automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shrouti1507