Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(INT-339): marketo response handler to handle static list removed and skipped statuses #2620

Merged
merged 7 commits into from
Sep 15, 2023
Merged

fix(INT-339): marketo response handler to handle static list removed and skipped statuses #2620

merged 7 commits into from
Sep 15, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

PR continued

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 requested review from a team as code owners September 15, 2023 08:01
@anantjain45823 anantjain45823 changed the title Fix.marketo nested response handling fix(INT-339): marketo response handler to handle static list removed and skipped statuses Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.05% 🎉

Comparison is base (2b38e2c) 86.83% compared to head (4c03b00) 86.88%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2620      +/-   ##
===========================================
+ Coverage    86.83%   86.88%   +0.05%     
===========================================
  Files          603      603              
  Lines        28158    28175      +17     
  Branches      6700     6704       +4     
===========================================
+ Hits         24450    24481      +31     
+ Misses        3371     3360      -11     
+ Partials       337      334       -3
Files Changed Coverage Δ
src/v0/destinations/marketo/util.js 90.69% <87.50%> (+5.69%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrouti1507
shrouti1507 previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/v0/destinations/marketo/util.js Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 87d8216 into develop Sep 15, 2023
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
@anantjain45823 @Sanjay-Veernala
fix(INT-339): marketo response handler to handle static list removed …
c49bb10 
…and skipped statuses (#2620)

* fix: marketo response handler

* small fix

* chore: comment addressed
@anantjain45823 anantjain45823 deleted the fix.marketoNestedResponseHandling branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@koladilip koladilip koladilip approved these changes

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@sauravlal15 sauravlal15 Awaiting requested review from sauravlal15 sauravlal15 is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anantjain45823 @yashasvibajpai @koladilip @shrouti1507