Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(INT-647): update workflow engine npm pkg name #2610

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

koladilip
Copy link
Contributor

Description of the change

Renamed pkg to @rudderstack/workflow-engine

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

krishna2020
krishna2020 previously approved these changes Sep 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d268f0) 86.83% compared to head (363678b) 86.83%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2610   +/-   ##
========================================
  Coverage    86.83%   86.83%           
========================================
  Files          603      603           
  Lines        28157    28157           
  Branches      6700     6700           
========================================
  Hits         24449    24449           
  Misses        3371     3371           
  Partials       337      337           
Files Changed Coverage Δ
src/cdk/v2/handler.ts 94.44% <ø> (ø)
src/cdk/v2/utils.ts 96.22% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip koladilip merged commit 1a99dd9 into develop Sep 14, 2023
@koladilip koladilip changed the title chore: update workflow engine npm pkg name chore(INT-647): update workflow engine npm pkg name Sep 15, 2023
@koladilip koladilip deleted the chore.update-workflow-engine branch September 15, 2023 06:28
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
* chore: update workflow engine npm pkg name

* fix: workflow engine version in package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants