Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google_cloud_function): refactor destination #2568

Closed
wants to merge 9 commits into from

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Sep 8, 2023

Description of the change

Resolves INT-135

  • Refactor destination to incorporate new UI fields and update response return format for consumption by server

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from a team as code owners September 8, 2023 04:33
@ujjwal-ab ujjwal-ab self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2b38e2c) 86.83% compared to head (f36986f) 86.83%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2568   +/-   ##
========================================
  Coverage    86.83%   86.83%           
========================================
  Files          603      602    -1     
  Lines        28158    28132   -26     
  Branches      6700     6696    -4     
========================================
- Hits         24450    24429   -21     
+ Misses        3371     3366    -5     
  Partials       337      337           
Files Changed Coverage Δ
...v0/destinations/google_cloud_function/transform.js 92.30% <100.00%> (+3.67%) ⬆️
src/v0/destinations/google_cloud_function/util.js 100.00% <100.00%> (+8.82%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ujjwal-ab
Copy link
Contributor Author

Closing this. Alternate #2652

@ujjwal-ab ujjwal-ab closed this Sep 26, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the feat.gcf-refactor branch December 16, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants