Skip to content

Commit

Permalink
Revert "fix: add missing field for pinterest_tag single product event…
Browse files Browse the repository at this point in the history
…s" (#3851)

This reverts commit f781a84.
  • Loading branch information
ItsSudip authored Nov 5, 2024
1 parent e5c5b0a commit f4100a3
Show file tree
Hide file tree
Showing 10 changed files with 8 additions and 82 deletions.
6 changes: 1 addition & 5 deletions src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,7 @@ steps:
"content_ids": (props.product_id ?? props.sku ?? props.id)[],
"contents": {
"quantity": Number(props.quantity) || 1,
"item_price": String(props.price),
"item_name": String(props.name),
"id": props.product_id ?? props.sku,
"item_category": props.category,
"item_brand": props.brand
"item_price": String(props.price)
}[]
};
- name: combineAllEcomFields
Expand Down
8 changes: 0 additions & 8 deletions test/apitests/data_scenarios/cdk_v2/failure.json
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -683,10 +679,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
12 changes: 0 additions & 12 deletions test/apitests/data_scenarios/cdk_v2/success.json
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -638,10 +634,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -720,10 +712,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -470,10 +466,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -552,10 +544,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -470,10 +466,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -289,10 +285,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -754,10 +754,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down Expand Up @@ -785,10 +781,6 @@
"content_ids": ["123"],
"contents": [
{
"id": "123",
"item_brand": "Gamepro",
"item_category": "Games",
"item_name": "Game",
"quantity": 11,
"item_price": "13.49"
}
Expand Down
13 changes: 3 additions & 10 deletions test/integrations/destinations/pinterest_tag/processor/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,7 @@ export const data = [
order_id: '50314b8e9bcf000000000000',
num_items: 2,
content_ids: ['123'],
contents: [
{ id: '123', item_name: 'undefined', quantity: 2, item_price: '25' },
],
contents: [{ quantity: 2, item_price: '25' }],
},
},
JSON_ARRAY: {},
Expand Down Expand Up @@ -2407,9 +2405,7 @@ export const data = [
order_id: '50314b8e9bcf000000000000',
num_items: 0,
content_ids: ['1234'],
contents: [
{ id: '1234', item_name: 'undefined', quantity: 1, item_price: 'undefined' },
],
contents: [{ quantity: 1, item_price: 'undefined' }],
},
},
JSON_ARRAY: {},
Expand Down Expand Up @@ -2670,7 +2666,7 @@ export const data = [
advertiser_id: '123456',
app_id: '429047995',
custom_data: {
contents: [{ item_price: 'undefined', quantity: 1, item_name: 'undefined' }],
contents: [{ item_price: 'undefined', quantity: 1 }],
currency: 'USD',
num_items: 0,
order_id: '50314b8e9bcf000000000000',
Expand Down Expand Up @@ -3501,7 +3497,6 @@ export const data = [
subtotal: 22.5,
affiliation: 'Google Store',
checkout_id: 'fksdjfsdjfisjf9sdfjsd9f',
category: 'Apparel',
},
anonymousId: '50be5c78-6c3f-4b60-be84-97805a316fb1',
integrations: { All: true },
Expand Down Expand Up @@ -3568,8 +3563,6 @@ export const data = [
{
quantity: 1,
item_price: 'undefined',
item_name: 'undefined',
item_category: 'Apparel',
},
],
currency: 'USD',
Expand Down
4 changes: 1 addition & 3 deletions test/integrations/destinations/pinterest_tag/router/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -815,9 +815,7 @@ export const data = [
order_id: '50314b8e9bcf000000000000',
num_items: 2,
content_ids: ['123'],
contents: [
{ id: '123', item_name: 'undefined', quantity: 2, item_price: '25' },
],
contents: [{ quantity: 2, item_price: '25' }],
},
},
{
Expand Down
11 changes: 3 additions & 8 deletions test/integrations/destinations/pinterest_tag/step/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -468,9 +468,7 @@ export const data = [
order_id: '50314b8e9bcf000000000000',
num_items: 2,
content_ids: ['123'],
contents: [
{ id: '123', item_name: 'undefined', quantity: 2, item_price: '25' },
],
contents: [{ quantity: 2, item_price: '25' }],
},
},
JSON_ARRAY: {},
Expand Down Expand Up @@ -2422,9 +2420,7 @@ export const data = [
order_id: '50314b8e9bcf000000000000',
num_items: 0,
content_ids: ['1234'],
contents: [
{ id: '1234', item_name: 'undefined', quantity: 1, item_price: 'undefined' },
],
contents: [{ quantity: 1, item_price: 'undefined' }],
},
},
JSON_ARRAY: {},
Expand Down Expand Up @@ -2689,7 +2685,7 @@ export const data = [
advertiser_id: '123456',
app_id: '429047995',
custom_data: {
contents: [{ item_name: 'undefined', item_price: 'undefined', quantity: 1 }],
contents: [{ item_price: 'undefined', quantity: 1 }],
currency: 'USD',
num_items: 0,
order_id: '50314b8e9bcf000000000000',
Expand Down Expand Up @@ -3609,7 +3605,6 @@ export const data = [
num_items: 0,
contents: [
{
item_name: 'undefined',
quantity: 1,
item_price: 'undefined',
},
Expand Down

0 comments on commit f4100a3

Please sign in to comment.