chore: resolve pr conflicts (#2739)

* fix: add event metadata to 298 status code responses * chore(release): 1.45.2 * fix: ut metadata map ts type * chore(release): 1.45.3 --------- Co-authored-by: srikanth <[email protected]> Co-authored-by: chandumlg <[email protected]>
rudderlabs · Oct 18, 2023 · e1410eb · e1410eb
1 parent 46b66da
commit e1410eb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/services/userTransform.ts b/src/services/userTransform.ts
@@ -7,6 +7,7 @@ import {
   ProcessorTransformationResponse,
   UserTransformationResponse,
   UserTransformationServiceResponse,
+  MessageIdMetadataMap,
 } from '../types/index';
 import {
   RespStatusError,
@@ -49,8 +50,15 @@ export default class UserTransformService {
         const eventsToProcess = destEvents as ProcessorTransformationRequest[];
         const transformationVersionId =
           eventsToProcess[0]?.destination?.Transformations[0]?.VersionID;
-        const messageIds = eventsToProcess.map((ev) => ev.metadata?.messageId);
-        const messageIdsSet = new Set<string>(messageIds);
+        const messageIds: string[] = [];
+        const messageIdsSet = new Set<string>();
+        const messageIdMetadataMap: MessageIdMetadataMap = {};
+        eventsToProcess.forEach((ev) => {
+          messageIds.push(ev.metadata?.messageId);
+          messageIdsSet.add(ev.metadata?.messageId);
+          messageIdMetadataMap[ev.metadata?.messageId] = ev.metadata;
+        });
+
         const messageIdsInOutputSet = new Set<string>();
 
         const commonMetadata = {
@@ -125,7 +133,7 @@ export default class UserTransformService {
             const droppedEvents = messageIdsNotInOutput.map((id) => ({
               statusCode: HTTP_CUSTOM_STATUS_CODES.FILTERED,
               metadata: {
-                ...commonMetadata,
+                ...(isEmpty(messageIdMetadataMap[id]) ? commonMetadata : messageIdMetadataMap[id]),
                 messageId: id,
                 messageIds: null,
               },

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -52,6 +52,10 @@ type Metadata = {
   transformationId: string;
 };
 
+type MessageIdMetadataMap = {
+  [key: string]: Metadata;
+};
+
 type UserTransformationInput = {
   VersionID: string;
   ID: string;
@@ -223,6 +227,7 @@ type ComparatorInput = {
 
 export {
   Metadata,
+  MessageIdMetadataMap,
   UserTransformationLibrary,
   ProcessorTransformationRequest,
   ProcessorTransformationResponse,