feat: addressed review comments

rudderlabs · Jan 3, 2024 · b0241cc · b0241cc
1 parent 565eee4
commit b0241cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/controllers/bulkUpload.ts b/src/controllers/bulkUpload.ts
@@ -1,7 +1,7 @@
 /* eslint-disable global-require, import/no-dynamic-require, @typescript-eslint/no-unused-vars */
 import { client as errNotificationClient } from '../util/errorNotifier';
 import logger from '../logger';
-import { CatchErr } from '../util/types';
+import { CatchErr, ContextBodySimple } from '../util/types';
 // TODO: To be refactored and redisgned
 
 const getDestFileUploadHandler = (version, dest) =>
@@ -45,7 +45,7 @@ export const fileUpload = async (ctx) => {
     return {};
   };
 
-  const { destType }: { destType: string } = ctx.request.body;
+  const { destType }: ContextBodySimple = ctx.request.body;
   const destFileUploadHandler = getDestFileUploadHandler('v0', destType.toLowerCase());
 
   if (!destFileUploadHandler || !destFileUploadHandler.processFileData) {
@@ -82,7 +82,7 @@ export const pollStatus = async (ctx) => {
     JSON.stringify(ctx.request.body),
   );
 
-  const { destType }: { destType: string } = ctx.request.body;
+  const { destType }: ContextBodySimple = ctx.request.body;
   const destFileUploadHandler = getPollStatusHandler('v0', destType.toLowerCase());
   let response;
   if (!destFileUploadHandler || !destFileUploadHandler.processPolling) {
@@ -117,7 +117,7 @@ export const getWarnJobStatus = async (ctx) => {
     JSON.stringify(ctx.request.body),
   );
 
-  const { destType }: { destType: string } = ctx.request.body;
+  const { destType }: ContextBodySimple = ctx.request.body;
   const destFileUploadHandler = getJobStatusHandler('v0', destType.toLowerCase());
 
   if (!destFileUploadHandler || !destFileUploadHandler.processJobStatus) {
@@ -153,7 +153,7 @@ export const getFailedJobStatus = async (ctx) => {
     JSON.stringify(ctx.request.body),
   );
 
-  const { destType }: { destType: string } = ctx.request.body;
+  const { destType }: ContextBodySimple = ctx.request.body;
   const destFileUploadHandler = getJobStatusHandler('v0', destType.toLowerCase());
 
   if (!destFileUploadHandler || !destFileUploadHandler.processJobStatus) {

diff --git a/src/util/types.ts b/src/util/types.ts
@@ -3,6 +3,9 @@ export type FixMe = any;
 
 export type CatchErr = any;
 
+export type ContextBodySimple = {
+  destType: string;
+};
 export interface Config {
   cdkEnabled?: boolean;
   cdkV2Enabled?: boolean;