Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: adding jobId for gaec
Browse files Browse the repository at this point in the history
shrouti1507 committed Dec 15, 2023
1 parent a457b3d commit 6b15d2c
Showing 3 changed files with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -129,5 +129,13 @@
"metadata": {
"type": "hashToSha256"
}
},
{
"destKey": "jobId",
"sourceKeys": ["properties.jobId"],
"required": false,
"metadata": {
"type": "toInt"
}
}
]
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@ const responseHandler = (destinationResponse) => {
// Ref - https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto
if (partialFailureError && partialFailureError.code !== 0) {
throw new NetworkError(
`[Google Ads Offline Conversions]:: partialFailureError - ${JSON.stringify(
`[Google Adwords Enhanced Conversions]:: partialFailureError - ${JSON.stringify(
partialFailureError,
)}`,
400,
Original file line number Diff line number Diff line change
@@ -1477,6 +1477,7 @@ export const data = [
userId: '12345',
properties: {
gclid: 'gclid1234',
jobId: '1',
conversionDateTime: '2022-01-01 12:32:45-08:00',
adjustedValue: '10',
currency: 'INR',
@@ -1565,6 +1566,7 @@ export const data = [
adjustmentType: 'ENHANCEMENT',
},
],
jobId: 1,
partialFailure: true,
},
JSON_ARRAY: {},

0 comments on commit 6b15d2c

Please sign in to comment.