chore: add constant for api_version

rudderlabs · Aug 26, 2024 · 4776544 · 4776544
1 parent b0fd614
commit 4776544
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 75 deletions.
diff --git a/src/v0/destinations/google_adwords_remarketing_lists/config.js b/src/v0/destinations/google_adwords_remarketing_lists/config.js
@@ -1,6 +1,8 @@
 const { getMappingConfig } = require('../../util');
 
-const BASE_ENDPOINT = 'https://googleads.googleapis.com/v17/customers';
+const API_VERSION = 'v17';
+
+const BASE_ENDPOINT = `https://googleads.googleapis.com/${API_VERSION}/customers`;
 const CONFIG_CATEGORIES = {
   AUDIENCE_LIST: { type: 'audienceList', name: 'offlineDataJobs' },
   ADDRESSINFO: { type: 'addressInfo', name: 'addressInfo' },
@@ -22,6 +24,7 @@ const consentConfigMap = {
 };
 
 module.exports = {
+  API_VERSION,
   BASE_ENDPOINT,
   TYPEOFLIST,
   attributeMapping,

diff --git a/test/integrations/destinations/google_adwords_remarketing_lists/dataDelivery/business.ts b/test/integrations/destinations/google_adwords_remarketing_lists/dataDelivery/business.ts
@@ -4,6 +4,8 @@ import {
   generateProxyV1Payload,
 } from '../../../testUtils';
 
+import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_remarketing_lists/config';
+
 export const commonHeaders = {
   Authorization: 'Bearer dummy-access',
   'Content-Type': 'application/json',
@@ -120,7 +122,7 @@ export const testScenariosForV0API = [
           headers: commonHeaders,
           params: commonParams,
           JSON: validRequestPayload1,
-          endpoint: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -154,7 +156,7 @@ export const testScenariosForV0API = [
           headers: commonHeaders,
           params: commonParams,
           JSON: invalidArgumentRequestPayload,
-          endpoint: 'https://googleads.googleapis.com/v15/customers/7693729834/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729834/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -217,7 +219,7 @@ export const testScenariosForV0API = [
           headers: commonHeaders,
           params: commonParams,
           JSON: validRequestPayload2,
-          endpoint: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -255,8 +257,7 @@ export const testScenariosForV1API = [
             headers: commonHeaders,
             params: commonParams,
             JSON: validRequestPayload1,
-            endpoint:
-              'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -299,8 +300,7 @@ export const testScenariosForV1API = [
             headers: commonHeaders,
             params: commonParams,
             JSON: invalidArgumentRequestPayload,
-            endpoint:
-              'https://googleads.googleapis.com/v15/customers/7693729834/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729834/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -346,8 +346,7 @@ export const testScenariosForV1API = [
             headers: commonHeaders,
             params: commonParams,
             JSON: validRequestPayload2,
-            endpoint:
-              'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
           },
           metadataArray,
         ),

diff --git a/test/integrations/destinations/google_adwords_remarketing_lists/network.ts b/test/integrations/destinations/google_adwords_remarketing_lists/network.ts
@@ -1,9 +1,9 @@
-import { enhanceRequestOptions, getFormData } from '../../../../src/adapters/network';
+import { API_VERSION } from '../../../../src/v0/destinations/google_adwords_remarketing_lists/config';
 
 export const networkCallsData = [
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs:create',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs:create`,
       data: {
         job: {
           type: 'CUSTOMER_MATCH_USER_LIST',
@@ -29,7 +29,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs/18025019461:addOperations',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs/18025019461:addOperations`,
       data: {
         enablePartialFailure: true,
         operations: [
@@ -71,7 +71,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs/18025019461:run',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs/18025019461:run`,
       headers: {
         Authorization: 'Bearer dummy-access',
         'Content-Type': 'application/json',
@@ -85,7 +85,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729834/offlineUserDataJobs:create',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729834/offlineUserDataJobs:create`,
       data: {
         job: {
           type: 'CUSTOMER_MATCH_USER_LIST',
@@ -111,7 +111,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729834/offlineUserDataJobs/18025019462:addOperations',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729834/offlineUserDataJobs/18025019462:addOperations`,
       data: {
         enablePartialFailure: true,
         operations: [{ create: { userIdentifiers: [{ hashedEmail: '[email protected]' }] } }],
@@ -167,7 +167,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v15/customers/7693729833/offlineUserDataJobs/18025019461:addOperations',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs/18025019461:addOperations`,
       data: {
         enablePartialFailure: true,
         operations: [
@@ -209,7 +209,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs:create',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs:create`,
       data: {
         job: {
           type: 'CUSTOMER_MATCH_USER_LIST',
@@ -243,7 +243,7 @@ export const networkCallsData = [
   },
   {
     httpReq: {
-      url: 'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs:create',
+      url: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs:create`,
       data: {
         job: {
           type: 'CUSTOMER_MATCH_USER_LIST',

diff --git a/test/integrations/destinations/google_adwords_remarketing_lists/processor/data.ts b/test/integrations/destinations/google_adwords_remarketing_lists/processor/data.ts
@@ -1,3 +1,4 @@
+import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_remarketing_lists/config';
 export const data = [
   {
     name: 'google_adwords_remarketing_lists',
@@ -69,8 +70,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -202,8 +202,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -322,8 +321,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -1424,8 +1422,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -2819,8 +2816,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -2899,8 +2895,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -4112,8 +4107,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -5412,8 +5406,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -6789,8 +6782,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -8099,8 +8091,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -9399,8 +9390,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -10794,8 +10784,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -10874,8 +10863,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11049,8 +11037,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11127,8 +11114,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11271,8 +11257,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11478,8 +11463,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11617,8 +11601,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11755,8 +11738,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -11895,8 +11877,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',
@@ -12038,8 +12019,7 @@ export const data = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint:
-                'https://googleads.googleapis.com/v17/customers/7693729833/offlineUserDataJobs',
+              endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/7693729833/offlineUserDataJobs`,
               headers: {
                 Authorization: 'Bearer dummy-access',
                 'Content-Type': 'application/json',