chore: update function as per review suggestion

rudderlabs · Dec 3, 2024 · 3eb5c55 · 3eb5c55
1 parent 70fa123
commit 3eb5c55
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js b/src/v1/sources/shopify/webhookTransformations/serverSideUtlis.js
@@ -45,15 +45,14 @@ const createPropertiesForEcomEventFromWebhook = (message) => {
  * @returns {String} anonymousId
  */
 const getAnonymousIdFromAttributes = async (event) => {
-  let anonymousId = null;
-  if (isDefinedAndNotNull(event) && isDefinedAndNotNull(event.note_attributes)) {
-    const noteAttributes = event.note_attributes;
-    const rudderAnonymousIdObject = noteAttributes.find(
-      (attr) => attr.name === 'rudderAnonymousId',
-    );
-    anonymousId = rudderAnonymousIdObject ? rudderAnonymousIdObject.value : null;
+  if (!isDefinedAndNotNull(event) || !isDefinedAndNotNull(event.note_attributes)) {
+    return null; // Return early if event or note_attributes is invalid
   }
-  return anonymousId;
+
+  const noteAttributes = event.note_attributes;
+  const rudderAnonymousIdObject = noteAttributes.find((attr) => attr.name === 'rudderAnonymousId');
+
+  return rudderAnonymousIdObject ? rudderAnonymousIdObject.value : null;
 };
 
 module.exports = {