fix: comments addressed

rudderlabs · Mar 7, 2024 · 1b3ab44 · 1b3ab44
1 parent f6b6607
commit 1b3ab44
Showing 1 changed file with 5 additions and 43 deletions.
diff --git a/src/cdk/v2/destinations/algolia/rtWorkflow.yaml b/src/cdk/v2/destinations/algolia/rtWorkflow.yaml
@@ -28,46 +28,13 @@ steps:
         $.handleRtTfSingleEventError(^[idx], .originalError ?? ., {})
       )[]
 
-  - name: separateDontBatchEventForProxy
-    template: |
-      {
-        dontBatchTrueEvents: $.outputs.successfulEvents{.metadata.dontBatch}[],
-        dontBatchFalseEvents: $.outputs.successfulEvents{!.metadata.dontBatch}[]
-      }
-
-  - name: batchSuccessfulEventsDontBatchTrue
+  - name: batchSuccessfulEvents
     description: Batches the successfulEvents
     template: |
-      let batches = $.chunk($.outputs.separateDontBatchEventForProxy.dontBatchTrueEvents, 1);
-      batches@batch.({
-        "batchedRequest": {
-          "body": {
-            "JSON": {"events": ~r batch.output[]},
-            "JSON_ARRAY": {},
-            "XML": {},
-            "FORM": {}
-          },
-          "version": "1",
-          "type": "REST",
-          "method": "POST",
-          "endpoint": {{$.ENDPOINT}},
-          "headers": batch[0].destination.Config.().({
-            "X-Algolia-Application-Id": .applicationId,
-            "X-Algolia-API-Key": .apiKey
-          }),
-          "params": {},
-          "files": {}
-        },
-        "metadata": ~r batch.metadata[],
-        "batched": true,
-        "statusCode": 200,
-        "destination": batch[0].destination
-      })[];
+      const dontBatchTrueEvents =  $.outputs.successfulEvents{.metadata.dontBatch}[];
+      const dontBatchFalseEvents = $.outputs.successfulEvents{!.metadata.dontBatch}[];
 
-  - name: batchSuccessfulEventsDontBatchFalse
-    description: Batches the successfulEvents
-    template: |
-      let batches = $.chunk($.outputs.separateDontBatchEventForProxy.dontBatchFalseEvents, $.MAX_BATCH_SIZE);
+      let batches = [...$.chunk(dontBatchFalseEvents, $.MAX_BATCH_SIZE), ...$.chunk(dontBatchTrueEvents, 1)];
       batches@batch.({
         "batchedRequest": {
           "body": {
@@ -93,11 +60,6 @@ steps:
         "destination": batch[0].destination
       })[];
 
-  - name: combineSuccessfulEvents
-    description: Combines the successfulEvents
-    template: |
-      [...$.outputs.batchSuccessfulEventsDontBatchFalse, ...$.outputs.batchSuccessfulEventsDontBatchTrue]
-
   - name: finalPayload
     template: |
-      [...$.outputs.failedEvents, ...$.outputs.combineSuccessfulEvents]
+      [...$.outputs.failedEvents, ...$.outputs.batchSuccessfulEvents]