-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lock plugins and integrations version by default #1956
base: hotfix/lock-components
Are you sure you want to change the base?
feat: lock plugins and integrations version by default #1956
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/lock-components #1956 +/- ##
=======================================================
Coverage 57.68% 57.69%
=======================================================
Files 485 485
Lines 16615 16617 +2
Branches 3356 3337 -19
=======================================================
+ Hits 9585 9587 +2
- Misses 5758 5834 +76
+ Partials 1272 1196 -76 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
…t.lock-components-version-sdk-2708
Quality Gate failedFailed conditions |
PR Description
I've deprecated the
lockIntegrationsVersion
andlockPluginsVersion
load API options as the SDK will use the integrations and plugins from the versioned directories by default.Additionally, the core SDK script tag will be identified using the dataset attribute first before using the fallback option.
The deployment workflow has been updated with the following changes:
/v3
)Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security