Skip to content

Commit

Permalink
chore: address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sai Sankeerth committed Dec 26, 2024
1 parent 6140b9c commit dc5553a
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ class MicrosoftClarity {
}

const identifyPromise = window.clarity('identify', userId, sessionId, customPageId);

Check warning on line 60 in packages/analytics-js-integrations/src/integrations/MicrosoftClarity/browser.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/MicrosoftClarity/browser.js#L60

Added line #L60 was not covered by tests
if (!!identifyPromise) { // Clarity SDK is ready
identifyPromise.catch(logger.error);
if (typeof identifyPromise?.then === 'function') { // Clarity SDK is ready
identifyPromise.catch(error => {
logger.error('The "identify" promise was rejected', error);

Check warning on line 63 in packages/analytics-js-integrations/src/integrations/MicrosoftClarity/browser.js

View check run for this annotation

Codecov / codecov/patch

packages/analytics-js-integrations/src/integrations/MicrosoftClarity/browser.js#L62-L63

Added lines #L62 - L63 were not covered by tests
});
}
if (context?.traits) {
const { traits } = context;
Expand Down

0 comments on commit dc5553a

Please sign in to comment.