fix: set anonymousId as previousId in alias API if userId is not present #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKannaniOS
reviewed
Dec 2, 2024
Sources/Classes/RSClient.m
Outdated
Comment on lines
243
to
245
| if (prevId == nil) { | ||
| prevId = self.anonymousId; | ||
| } |
There was a problem hiding this comment.
To simplify multiple if conditions, use the Ternary Conditional Operator (?:) as shown below.
NSObject *prevId = [traits objectForKey:@"userId"] ?: [traits objectForKey:@"id"] ?: self.anonymousId;
|
SKannaniOS
approved these changes
Dec 2, 2024
ChryssaAliferi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aliasAPI, setanonymousIdaspreviousId, ifuserIdis not present.aliasevent is made before anyidentifyevent is made. In this case,previousIdneeds to be set asanonymousIdbut currently this field is not present. So we've added a fix to add the correct value.