fix: fix SwiftUI mangled names #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TizianoCoroneo, Thank you for raising this, we will check this out. |
TizianoCoroneo
changed the title
|
Hey @TizianoCoroneo, Can you please sign the CLA here to take this forward ? |
Done! |
|
Thank you @TizianoCoroneo for signing the CLA, merging this now. |
desusai7
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the name mangling of the screen events when the automatic screen tracking tries to capture SwiftUI's views.
The issue was cause by the usage of
NSStringFromClass, that takes the unique mangled name of a Swift class as seen from the ObjC runtime. Using Swift's standard libraryString(describing: type(of: self))instead returns us the demangled name.I have implemented this feature on top of the 2.4.3 tag. I'm unsure of what branch to target.
Here's an example:
LoadingView<ActiveEventsFilters, BrowseEventsView>